Apologies for the slow review here. There is one minor problem and one more serious one.
The minor problem is that Vcs-Git and Vcs-Browser in debian/control point to a non-existent repo on salsa (I assume this is just default output from dh-make-golang or whatever it is called?). Can you please update this to point to the correct locations? (presumably the repo on github but you can decide!) The more serious problem is that debian/copyright appears to be missing some files in vendor. In particular running 'lrc' from licesnserecon reports the following: C.: Versions: licenserecon '6.0' licensecheck '3.3.9-1ubuntu1' Parsing Source Tree .... Reading d/copyright .... Missing Files: Paragraph for debian/ Running licensecheck .... d/copyright | licensecheck GPL-3+ | Expat vendor/github.com/cpuguy83/go-md2man/v2/LICENSE.md GPL-3+ | BSD-3-clause vendor/github.com/google/uuid/LICENSE GPL-3+ | BSD-2-clause vendor/github.com/russross/blackfriday/v2/LICENSE.txt GPL-3+ | BSD-2-clause vendor/github.com/russross/blackfriday/v2/block.go GPL-3+ | BSD-2-clause vendor/github.com/russross/blackfriday/v2/html.go GPL-3+ | BSD-2-clause vendor/github.com/russross/blackfriday/v2/inline.go GPL-3+ | BSD-2-clause vendor/github.com/russross/blackfriday/v2/markdown.go GPL-3+ | BSD-2-clause vendor/github.com/russross/blackfriday/v2/smartypants.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/LICENSE GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/data_source.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/deprecated.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/error.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/file.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/helper.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/ini.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/key.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/parser.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/section.go GPL-3+ | Apache-2.0 vendor/gopkg.in/ini.v1/struct.go Apache-2.0 | Apache-2.0 and/or Expat vendor/gopkg.in/yaml.v3/LICENSE The yaml one is a false positive but the others appear to stem from missing stanzas in d/copyright. Can you please fix this. It might be worth considering running "lrc" as part of your CI (you can suppress the false positive in debian/lrc.config). Otherwise the packages looks good to go. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2107478 Title: [needs-packaging] ubuntu-insights To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2107478/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
