I followed my expanded test from comment #17 on Ubuntu 24.10 and verified the failure case.
I then installed sbuild 0.85.10ubuntu1.1 and verified that the test passes now. sbuild did not try to make an ~/.sbuildrc file for me so I didn't have the separate bug there. ** Description changed: [Impact] With the increasing adoption of tools like authd, it's very likely that Linux desktop users in corporate environments end up with their usernames like '[email protected]', what doesn't play nice with sbuild/schroot. Without properly escaping the username, the '@' character ends up being interpreted as a string interpolation what breaks the lock_chroot() subroutine. Fore more information about the issue, please check the upstream bug: https://salsa.debian.org/debian/sbuild/-/issues/4 - [ Test plan ] 1. Make sure to have a user account containing the '@' character in its name, such as '[email protected]'. 2. Make sure to have a schroot environment ready. `mk-sbuild oracular` for example to create one for oracular. Note: the mk-sbuild command is provided by the ubuntu-dev-tools package, so make sure to have it installed. 3. Retrieve the sources of a simple package: `pull-lp-source hello noble` - 4. Build the binary package with sbuild: `cd hello-2.10/ && sbuild -d noble-amd64` (adjust the schroot environment name according to your computer's architecture) + 4. Build the binary package with sbuild: `cd hello-2.10/ && sbuild -d oracular-amd64 --no-clean-source` (adjust the schroot environment name according to your computer's architecture) Expected results without the patches herein proposed is a failure like: ``` I: NOTICE: Log filtering will replace 'var/run/schroot/mount/plucky-amd64-c9a17ed0-5932-4df1-ad6e-d4df512a37b0' with '<<CHROOT>>' Possible unintended interpolation of @org in string at -e line 50. Global symbol "@org" requires explicit package name (did you forget to declare "my @org"?) at -e line 50. Execution of -e aborted due to compilation errors. E: Error locking chroot session: skipping livecd-rootfs ``` Building the package should proceed normally with the patches applied. - [ Where problems could occur ] - The scope of the changes herein proposed is so small and self-contained that I + The scope of the changes herein proposed is so small and self-contained that I don't expect any issues arising from it under any circumstances. - [ Other Info ] I'm skipping 'Questing', as I expect it to receive the fix via debian merges, sbuild version 0.89.2 (just accepted into Debian unstable) contains this patch (alongside other stuff). ** Tags removed: verification-needed verification-needed-oracular ** Tags added: verification-done verification-done-oracular -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2109853 Title: [SRU] Make sbuild usable for '[email protected]' users To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sbuild/+bug/2109853/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
