The origin of this dirty hack was for Tributo Lunar Lake oem platform (with gpio ACPI ID INTC10B6). The usbio bridge protocol received updates from v0.7 to v1.0, such that the payload field in the end of struct usbio_msg should not be included at control message transactions. The xfer size for LNL should be 4, and 8 for previous CPU generations.
When b022c9a73d steps in, the variable "actual" is now assigned with a smaller value 4, the packed struct size of struct usbio_msg, instead of 8, the size of a pointer on amd64 platforms. Therefore, dropping the previous dirty hack and applying commit b022c9a73d at the same time is a valid fix for Lunar Lake platforms. But not for older ones. Older platforms, and therefore older usbio bridge protocol, still expect 8 bytes. And that will certainly become a regression if not handled correctly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2102186 Title: wrong packet header size calculation To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/usbio-drivers/+bug/2102186/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
