Okay Seyeong some feedback items:

The version is wrong, it needs to be 4.0.0-2ubuntu1.1 instead of
4.0.0-2ubuntu2. 2 could be taken by groovy etc and already used, so we
follow the security team versioning in
https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

I would like it if you elaborate a bit more in the debian/changelog for
what the changes actually do. Think like you are a user who has no idea
if they want the update or not, and are reading the changelog to decide.
You want to explain what the update does.

I would also like it if you put "lp<number>" infront of the patch names.
It helps differentiate the patches from debian patches and also makes it
easier to identify what is part of what SRU. In the case of multiple
patches, do what I did with lp<number>-1-name, lp<number>-2-name etc.

Your SRU template needs to be more clear. You can merge / delete the
original reporter description into your one for normal server bugs. For
cloud ones associated with upstream openstack project, keep the original
description intact.

I tidied up the SRU template a bit, try and follow this sort of format
next time. Put the commits that fix the issue in [Other info], as well
as any upstream bugs. The testcase needs to exist and needs to explain
how we will actually verify the new packages actually fix the issue.

Its okay to put full gdb backtraces in. I took the backtrace you got
from the case and placed it in the description since it shows the
accurate stacktrace.

All sponsored to Focal now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2023263

Title:
  nrpe crash in free() upon connection tear down

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nagios-nrpe/+bug/2023263/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to