Here are my comments - sorry I think this got double-reviewed since Frank asked through multiple channels:
> QEMU part of this enablement work is tracked in bug #2049698 It'd be better to track these items together in one bug with multiple bug tasks. But either way, if this part is dependent on that part, and this part is the real user story were trying to fix, then please make it part of your Test Plan on both sides to land and test both changes in -proposed together before releasing them at the same time. This way, if something in the qemu part needs further tweaking to make the libvirt part work, we won't have to SRU qemu twice. See: https://documentation.ubuntu.com/sru/en/latest/howto/common- issues/#test-plan "The Test Plan or verification only tested part of the user story that we are fixing with a series of SRUs" > but if anything goes wrong, it could affect the overall capabilities detection of libvirt, leading to invalid control commands being generated for QEMU and therefore a change in behavior How will this be mitigated by our testing? I don't see any testing of non architecture specific behaviour in libvirt; please could you add that to the Test Plan? > 2b) with patch set: guest does not start from first device > AND an attempt is made to boot from the next device in the boot order > So there is a potential change in behavior in case 2) b). So the behaviour change would be that a device will start to boot when it failed to boot previously? I think this is OK. The bug that we're fixing is that the user has specified a fallback to the second boot device, and that fallback isn't occuring. By definition, when we fix a bug in an SRU we're changing behaviour by making what previously failed to work, work. That mere fact doesn't make it unacceptable, and looking at the bigger picture, I don't see a major issue with starting to do what the user is requesting when we previously didn't. The user always has the option to stop requesting it if they don't want that behaviour. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2051239 Title: [25.04 FEAT] [VS1807] KVM: Full boot order support - libvirt part To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/2051239/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
