The bug title is much better - thanks. The test plan you describe in comment 15 is much better, but I think there are a couple of things still needed, please. Since this is hardware specific, what matrix of hardware are you intending to test? For example, if using ffmpeg, then are you testing both with and without the relevant hardware to ensure that behaviour for those without this hardware is not regressed? Or would that not make a useful test, and if so, why?
> To be clear, not all of the tests pass, but there are no test regressions when upgrading from 24.3.4 media driver + 22.5.2 gmmlib to 24.4.4 + 22.5.5 across the platforms I tested. I think that's fine, but then it should be part of the documented test plan as to how to validate that there are no test regressions please. > I'm not sure what you mean here. I'm installing the version bumped packages that would be going into the SRU so that I can test against them to make sure they all function together. I don't have the power to put packages into proposed, and it doesn't seem like anyone adds those new versions to proposed unless I prove thorough testing of the stack to show that it's fit for upload. If you add the requested versions to proposed, I'd be happy to test those versions. If we want everything out of the PPA, I'll add libvpl 2.14.0 to this request as well I do expect you have done some testing of the stack to show that it's good for upload, but that's not what I'm reviewing for here. I'm reviewing what testing you intend to do of the final built proposed binaries that will be released, and that requires that you test using binaries that are either already shipped by Ubuntu or will be released as part of this update. > If you add the requested versions to proposed, I'd be happy to test those versions. If we want everything out of the PPA, I'll add libvpl 2.14.0 to this request as well This one, but note that the SRU reviewer (me) is not the person who uploads the packages to the archive (your sponsor). Please see https://canonical-sru-docs.readthedocs- hosted.com/en/latest/explanation/roles/ for the distinction. The SRU requirement is that you have a user impact statement ("Intel Battlemage cards lack hardware encode support" is good, albeit a little inverted), that you propose an SRU of multiple packages as required to fix that user impact, the test plan uses only those packages and not external sources so that we can validate the final binaries that will land, and then we execute on that once the plan is accepted and the upload accepted and built into proposed. I hope that explains things. Please ask your sponsor for further help as needed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2098413 Title: [SRU] Intel Battlemage cards lack hardware encode support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/intel-gmmlib/+bug/2098413/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
