I'm sorry, I have been responding to the mails I have received about
this, trying to clarify things, but they have not been added to the bug.

You may want to verify, but I believe that if grub-probe FAILS (returns an 
error) it is because the the file system is not one that grub can deal with 
(one case I found was a lvm snapshot which grub cannot boot from).
Contrary to Heitor's comment that "we we *do* want the script to continue in 
some of these cases" it is pointless to continue on and execute mounted probes 
and we don't want an entry in the cfg (as it will be unbootable)

simply add

    + debug "un-mountable using GRUB, bad filesystem?"
    + mount=
    + do_unmount

 The "do_unmount" is optional as it is forced at the end of the script,
the "mount=" signals not to do any more tests

cleans up the bug (leaving filesystems mounted) and "does no harm"

When I was playing around (testing) this the error messages from grub-probe 
were confusing/undecipherable.
Depending on the test regime and any added test cases for this problem (the 
other file system that caused problems was a system on a thin-lvm), I might 
suggest losing the error messages from grub-probe (2>/dev/null) and adding an 
error message "system found on an partition unbootable by GRUB" as I believe 
that is the root cause of this problem

Hope this helps

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1987679

Title:
  os-prober leaves filesystems (lvm-thin, lvm snap) mounted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1987679/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to