Something else that I find troublesome is that the test plan is only focused on the change being introduced in this SRU, namely, the new build flags. And in a passive way: just check if the resulting binary has some attribute, and if the build logs have a certain flag.
This is missing an actual check to see if xfsprogs is still working correctly. There are no DEP8 tests to at least perform a simple smoke test. I think this needs improving. We should at the very least test basic functionality, like creating and checking filesystems, resize (grow), etc. It would be very bad if this update triggered an assertion error in one of these functions due to the new FORTIFY_SOURCE=3 flag, for example. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2076309 Title: [SRU] xfsprogs missing frame pointer To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xfsprogs/+bug/2076309/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
