With the nose fix, git-buildpackage no longer fails to build from
source. But you are right that any ubuntu change we make (which adds an
ubuntuN suffix) will break the build in the version check.

That being said, the package is a sync with debian, and debian has a new
0.9.35 in unstable already, which we will sync once plucky is open for
development, which should happen shortly.

Should we add a delta to fix a build problem that only happens when we
add an ubuntu suffix to the package? Actually, even a "build1" no-change
rebuild seems to break it.


So, at the moment there is no FTBFS in git-buildpackage. There would be
one, if we added an ubuntu delta, or did a no-change rebuild. Also with
that in mind, the patch:

+        m = re.match(r"(.+)ubuntu\d+", version)
+        if m is not None:
+            version = m.group(1)

Won't fix the problem of a "build1" suffix being added:
(...)
  File "/usr/lib/python3/dist-packages/packaging/version.py", line 202, in 
__init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: '0.9.34build1'

So I think a better fix is needed. I'll mark the git-buildpackage task
as incomplete for now.

** Changed in: git-buildpackage (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2083051

Title:
  nose, git-buildpackage FTBFS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/git-buildpackage/+bug/2083051/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to