Hey Loic,

Thanks for your review.
A newer version (optee-os-s32 - 3.18-bsp37.0-0ubuntu1~ppa5) is uploaded to PPA.
The changes are listed below.
(commit: 
https://git.launchpad.net/~nemos-team/nemos/+git/optee-os-s32/commit/?id=69b90f29d401ef8f323b17413967cf437e2d83bc)

=> I think this should be "s32g2" instead of "export-ta_arm64" since optee is 
built with PLATFORM=s32 PLATFORM_FLAVOR=s32g2
[Laider] Align with optee-os_4.2.0-3.dsc from Debian
         The tee-*_v2.bin is installed to /usr/lib/optee/s32g2/
         The export-ta_arm64 content is installed to /usr/lib/optee-os-dev/s32

=> I think we should align the build command between optee-os and optee-os-s32 
(config flags)
[Laider] We can't do it due to the flags got building fail with Launchpad PPA
Ex.
-O2 flag is not supported

2)5)7)...
7) the reason for 
debian/patches/drivers-hse-Remove-access-to-HSE-RNG-without-proper-init.patch 
should be
documented in the patch
[Laider] The README.Debian is added with why we have this package, the patch, 
and explain how to build HSE version.
         It also includes how to build optee-test with the content of optee-* 
dev package.
         And 

3) optee-os-s32 build-depends on nemos-dev-cert and nemos-dev-key...
[Laider] Indeed, we can use default key for optee-os and optee-test (sign TAs)
         The key is changed back to use the default one.
  
4) IMO the build-dep on binutils can be dropped; binutils is pulled through gcc 
through build-essential, so pretty much no package will list it explicitly
[Laider] Agree with it, binutils is removed.

6) keep changelog history
[Laider] Thanks, I keep the changelog history at the latest version

** Changed in: ubuntu
       Status: In Progress => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2034648

Title:
  [needs-packaging] optee-os-s32

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2034648/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to