I do like the addition of the compare test; it's a bit "magic" but the fact it's comparing against an image from the actual installation (/usr/share/xrdp/xrdp_logo.bmp) does demonstrate the operation of the package very nicely.
I did try and run the tests locally under autopkgtest but unfortunately they fail because the test is using "sudo" without declaring "needs- sudo" in the restrictions (without this, sudo isn't installed/configured for the test suite). Having patched that, the tests failed to run in a chroot due to the presence of needs-sudo (unsurprisingly), so I attempted with a full VM, but that failed with a badpkg error in imagemagick. So, this looks promising, but may need a bit more work to be certain it'll pass in production. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2060976 Title: Create autopkgtest To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/2060976/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
