The patches look fine and certainly fix the issue described. One thing
that does concern me slightly is that this only patches one instance of
XMMS_PATH_MAX and there's several more scattered throughout the code
that look like they could potentially be hit by long pathnames. Wouldn't
it be preferable to simply #define XMMS_PATH_MAX PATH_MAX in
xmmsc_util.h

Anyway, I'll sponsor this as is but I've added a note to the upstream
PR.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2018449

Title:
  [SRU] `xmms2 add --playlist ... ` causes a core dump

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xmms2/+bug/2018449/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to