[Summary] MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs.
Required TODOs: - The whole testing story is really weak in term of autopkgtests and build tests. I would require a manual test plan to cover for that on each release as if there were none. Recommended TODOs: - (Nitpick): I think it’s the right time, as it’s going to replace gnome-terminal, to explore patching the background color to look more like Ubuntu. I don’t think it’s something we want to reach later on, close to Final Freeze. [Duplication] There is no gnome-terminal in main providing the same functionality, but this application is going to replace it. [Dependencies] OK: - no other Dependencies to MIR due to this - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have odd Built-Using entries OK: - not a go package, no extra constraints to consider in that regard [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats - does not open a port/socket - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) [Common blockers] OK: - does not FTBFS currently - no new python2 dependency Problems: -> The whole testing story is really weak in term of autopkgtests and build tests. I would require a manual test plan to cover for that on each release as if there were none. [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking not applicable for this kind of code. - d/watch is present and looks ok - Upstream update history is good- warning, this is still a really new project. - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far - no massive Lintian warnings - d/rules is rather clean - It is not on the lto-disabled list [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* - part of the UI, desktop file is ok - translation present ** Changed in: gnome-console (Ubuntu) Status: New => Incomplete ** Changed in: gnome-console (Ubuntu) Assignee: Didier Roche (didrocks) => Jeremy Bicha (jbicha) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1973828 Title: [MIR] gnome-console To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-console/+bug/1973828/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs