Review for Package: src:libapache2-mod-auth-openidc Author: @joalif Reviewed-by: @slyon
[Summary] libapache2-mod-auth-openidc provides the mod_auth_openidc authentication/authorization module for Apache2. This module enables an Apache 2.x web server to operate as an OpenID Connect Relying Party (RP) towards an OpenID Connect Provider (OP). It relays end user authentication to a Provider and receives user identity information from that Provider. It then passes on that identity information (a.k.a. claims) to applications protected by the Apache web server and establishes an authentication session for the identified user. MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does need a security review. List of specific binary packages to be promoted to main: libapache2-mod- auth-openidc_2.4.10-1build1_amd64.deb Notes: - This package is security sensitive as it is exposed to the open web, being an apache2 module/plugin. It processes arbitrary URLs/web content as its input - This package touches with two current transitions: prce2 and openssl3 Required TODOs: - check runtime dependencies in universe (libcjose0, libhiredis0.14), they need to be dropped (if possible) or need a MIR as well - drop the non functional autopkgtest (wrong indication of test coverage) - enable symbols tracking for mod_auth_openidc.so - build the package with pcre2: https://people.canonical.com/~ubuntu-archive/transitions/html/pcre3-to-pcre2.html - check build-time warnings (especially about openssl3), if not critical mention it in this bug report; it can then be downgraded to a "recommended TODO" and fixed later. Otherwise, please resolve those issues. Recommended TODOs: - The package should get a team bug subscriber before being promoted - a functional autopkgtest should be added - Update to the latest upstream version 2.4.11 (still very new) https://github.com/zmartzone/mod_auth_openidc/releases [Duplication] - There is no other package in main providing the same functionality. [Dependencies] OK: - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: - Other runtime dependencies in universe, need MIR: - libcjose0 (>= 0.4.1) - libhiredis0.14 (0.14.1-2) [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have odd Built-Using entries - not a go package, no extra constraints to consider in that regard - No vendoring used, all Built-Using are in main Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not open a port/socket - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with security attestation (secure boot, tpm, signatures) Problems: - does parse data formats - does deal with system authentication (eg, pam), etc) - does process arbitrary web content (bearer/authentication tokens) [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - no new python2 dependency Problems: - the package has one autopkgtest but it does nothing [Packaging red flags] OK: - Ubuntu does not carry a delta - d/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - d/rules is rather clean - It is not on the lto-disabled list Problems: - symbols tracking not in place - the current release is not packaged (2.4.11 got released a few weeks ago, but .10 should still be fine) [Upstream red flags] OK: - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid - no dependency on webkit, qtwebkit, seed or libgoa-* - not part of the UI for extra checks - no translation present, but none needed for this case Problems: - Warnings during the build (about openssl3 and others), that should be checked https://launchpadlibrarian.net/573067374/buildlog_ubuntu-jammy-amd64.libapache2-mod-auth-openidc_2.4.10-1build1_BUILDING.txt.gz - important bug in Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000069 libapache2-mod-auth-openidc: depends on obsolete pcre3 library ** Bug watch added: Debian Bug tracker #1000069 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000069 ** Changed in: libapache2-mod-auth-openidc (Ubuntu) Status: New => Incomplete ** Changed in: libapache2-mod-auth-openidc (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => Corey Bryant (corey.bryant) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959722 Title: [MIR] libapache2-mod-auth-openidc To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libapache2-mod-auth-openidc/+bug/1959722/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
