Review for Package: src:libyang2 [Summary] libyang2 source package is a parser toolkit for IETF YANG data modelling. It provides : * the library (libyang2) which implements functions to process schemas expressed in YANG data modelling language. The schemas primarily describe network equipment configuration. * development files (libyang2-dev) * executable tools (libyang2-tools, libyang-tools) which can be used for the creation of IETF YANG schemas.
MIR team ACK This does need a security review because it parses data formats, so I'll assign ubuntu-security. List of specific binary packages to be promoted to main: libyang2, libyang2-dev Specific binary packages built, but NOT to be promoted to main: libyang2-tools, libyang-tools (no dependency on them) Notes: Recommended TODOs: - The package provides one autopackage test. It would be nice to have more. - In the buildlog (https://launchpadlibrarian.net/581476001/buildlog_ubuntu-jammy-amd64.libyang2_2.0.112-6ubuntu1_BUILDING.txt.gz) there are 2 warnings reported many times. It would be nice to report them upstream to be fixed. The warnings are : ../.././src/parser_json.c: In function ‘lydjson_data_skip’: ../.././src/parser_json.c:304:46: warning: ‘current’ may be used uninitialized in this function [-Wmaybe-uninitialized] ../.././src/parser_json.c:283:39: note: ‘current’ was declared here ../.././src/schema_compile_node.c: In function ‘lys_compile_node_’: ../.././src/schema_compile_node.c:2438:19: warning: ‘list’ may be used uninitialized in this function [-Wmaybe-uninitialized] ../.././src/schema_compile_node.c:2426:28: note: ‘list’ was declared here [Duplication] - There is no other package in main providing the same functionality. [Dependencies] OK: - no other Dependencies to MIR due to this - checked with check-mir - not listed in seeded-in-ubuntu - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have odd Built-Using entries - not a go package, no extra constraints to consider in that regard - No vendoring used, all Built-Using are in main Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not open a port/socket - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) Problems: - package does parse data-formats [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - does have a non-trivial test suite that runs as autopkgtest - no new python2 dependency Problems: None [Packaging red flags] OK: - Ubuntu does carry a delta, but it is reasonable and maintenance under control - symbols tracking is in place - d/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - d/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* - not part of the UI for extra checks Problems: None ** Changed in: libyang2 (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1958293 Title: [MIR]: libyang2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libyang2/+bug/1958293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
