Hello!

> This is meant in addition to 
> https://bugs.launchpad.net/ubuntu/focal/+source/libreoffice/+bug/1929999 
> not as a replacement.

just to reinforce this, the backport definitely shouldn't be relied on
as a replacement for proper SRU work, so that bug should definitely
continue to be discussed and hopefully the SRU completed.

> A recent set of upstream's automated jenkins testing can be found here:
...
> Launchpad testing. The libreoffice packages include autopkgtests that were 
> run and verified as passing.
...
> General smoke testing of all the applications in the office suite were 
> carried out by going through the manual testplan

Very good, I think both the upstream tests as well as the autopkgtests
for the backported package are important. And for a package like this
that's very end-user-focused it's very good to see manual testing as
well.

I have only 2 concerns with the backport:

1) looking at the debdiff, it seems the backport did require some
changes. I'd like to see the specifics of the changes required for the
backport at least mentioned in the changelog. Additionally, I have some
specific comments on the backport changes:

You've made quite a few changes in d/control, to adjust the minimum
version of dpkg-dev as well as removing some deps and adding others.

For the reduced dpkg-dev min version, where is the corresponding change
in code? Why does the newer libreoffice depend on a newer dpkg-dev, but
appears to also work fine using the older version? Does the libreoffice
in hirsute simply include a dpkg-dev min version that it doesn't
actually need?

For the removed/added deps, which also have a change in d/rules to
compile without (or with) them; I don't think this is necessarily a
problem, assuming it really needs to be done for the backport, but it
definitely should be listed in the changelog, since removing deps
presumably will remove some functionality in the backported version
(right?)

2) the specific version of the backported package should include a suffix with 
'bpo':
https://wiki.ubuntu.com/UbuntuBackports#Preparing_the_Backported_Package

This is a new requirement as we just recreated the backports process, so
if you were using the 'backportpackage' tool it probably got the version
wrong.


I rejected the current upload, but if you can reupload with the two concerns 
above addressed, I don't see any other problems with it.

Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1950467

Title:
  [BPO] libreoffice 7.1.7 for focal

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1950467/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to