Thank you Steve for taking a look. You are right on all counts.
It appears the code to pre-create log files is unnecessary. If you consider this a blocker then we can remove it in this release. Otherwise we will remove it in 27.4 We purposefully kept the purpose of the enable_periodic_license_check function to _enabling_ when run on GCP LTS non-attached instances. You are right that the timer will not be disabled during postinst when upgrading to a non-LTS; however, the timer will notice that it is non- LTS and disable itself next time it runs. The code that does this is here: https://github.com/canonical/ubuntu-advantage-client/blob/release-27/uaclient/jobs/license_check.py#L36 And our integration test for the timer disabling itself on non-LTS is here: https://github.com/canonical/ubuntu-advantage-client/blob/release-27/features/license_check.feature#L47 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942929 Title: [SRU] ubuntu-advantage-tools (27.2.2 -> 27.3) Xenial, Bionic, Focal, Hirsute To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1942929/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
