** Description changed: [Impact] sos's networking plugin may trigger the devlink kernel module to load. We don't want sos to modify/change/alter the state of a machine whatsoever, especially during troubleshooting. But it may be the case for the networking plugin, depending on the running kernel configuration. As a side note, this is also causing Bionic autopkgtest to fails as it is tested w/ 4.15 series kernel by default. 'simple.sh' (sos testsuite part of the autopkgtest) will report a failure as follows: "new kernel modules loaded during execution" [Test case] On a 4.15 kernel (Bionic) On a bare metal system: root@srv:~# lsmod | grep -i devlink root@srv:~# sos report -o networking root@srv:~# lsmod | grep -i devlink devlink 45056 0 Not reproducible on Bionic w/ 5.4 kernel for instance Reason: config-4.15.0-140-generic:CONFIG_MAY_USE_DEVLINK=m config-5.4.0-70-generic:CONFIG_NET_DEVLINK=y CONFIG_MAY_USE_DEVLINK: Drivers using the devlink infrastructure should have a dependency on MAY_USE_DEVLINK to ensure they do not cause link errors when devlink is a loadable module and the driver using it is built-in. [Where problem could occur] + The fix first checks for /sys/class/devlink before adding the devlink commands to the networking plugin. If this path changes in future kernels, or it becomes possible to collect devlink information without this path being present, we'll miss that information in sosreports. It's also possible that in future kernels, additional modules get loaded due to the devlink commands, so we should also be on the lookout for those changing the system state between sos executions. + + The above are very unlikely scenarios in any case, and we should get + previous notice of such changes. The patchset will also be tested with + the now fixed autopkgtests, and that should give a bit more confidence + in the fixes. [Other information] + This is fixed by upstream commit: + - c90315e23c57 "[networking] check for the presence of devlink" Upstream issues: https://github.com/sosreport/sos/commit/e7801c5bf50d129f93559f8c459a3c96bba1375e
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1923661 Title: [sos41][networking] May invoke devlink module when not loaded depending on how the kernel is configured To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1923661/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
