** Description changed:

+ [Impact]
+ 
+  * Upstream would like Ubuntu packages to use the build options closest
+ to upstream's practice.
+ 
+ [Test Case]
+ 
+  * Check the build logs if the following options are used (-mod=readonly is 
not needed because the build does not use go mod):
+   -ldflags="-s -w -X main.version=$(shell dpkg-parsechangelog -S Version)"
+ 
+ [Where problems could occur]
+ 
+  * The build options just strip the binary and set the current version.
+ None of those should cause any problem.
+ 
+ [Original Bug Text]
+ 
  Upstream's build parameters;
  
  override_dh_auto_build:
         dh_auto_build -O--buildsystem=golang -- -ldflags="-s -w -X 
main.version=$(VERSION)-$(RELEASE)" -mod=readonly
  
   - Strip the binary
   - Set main.version
  
  (Upstream asked for that.)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1900897

Title:
  Please build the package as upstream does

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-guest-agent/+bug/1900897/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to