The attached debdiff contains the proposed fix for xtables-addons in Focal.
A build can be found on the following PPA: https://launchpad.net/~kleber-souza/+archive/ubuntu/ppa/+sourcepub/11809351/+listing-archive-extra The source package can be found at: https://kernel.ubuntu.com/~ksouza/lp1907109/focal/ ** Description changed: + [Impact] + Focal linux 5.4.0-57.63 backported from v5.4.78 upstream stable release the following commit, which broke the build of xtables-addons dkms modules on Focal and Bionic for all 5.4 kernels based on this release: + + "netfilter: use actual socket sk rather than skb sk when routing harder" + (Upstream commit 46d6c5ae953cc0be38efd0e469284df7c4328cf8). + + [Test case] + Install xtables-addons-dkms package. + + [Fix] + The proposed fix is a backport of a fix applied to xtables-addons 3.9-1ubuntu1 on the development release (hirsute). This patch fixes the API change for the 5.10.0 kernel, the proposed fix extends the check for all 5.4.y kernels after 5.4.78. + + [Where problems could occur] + If the macros check are not done correctly, the dkms packages could fail building again. + + ----- Testing failed on: amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/x/xtables-addons/20201130_225717_5a440@/log.gz arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/x/xtables-addons/20201130_231636_db3fa@/log.gz armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/armhf/x/xtables-addons/20201130_230156_f17a8@/log.gz ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/x/xtables-addons/20201130_231718_e060b@/log.gz s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/x/xtables-addons/20201130_225000_2fcfa@/log.gz Build of the dkms is failing with the following error: /var/lib/dkms/xtables-addons/3.8/build/extensions/xt_DELUDE.c: In function ‘delude_send_reset’: /var/lib/dkms/xtables-addons/3.8/build/extensions/xt_DELUDE.c:125:30: error: passing argument 2 of ‘ip_route_me_harder’ from incompatible pointer type [-Werror=incompatible-pointer-types] 125 | if (ip_route_me_harder(net, nskb, addr_type)) | ^~~~ | | | struct sk_buff * In file included from ./include/linux/netfilter/x_tables.h:245, from /var/lib/dkms/xtables-addons/3.8/build/extensions/xt_DELUDE.c:20: ./include/linux/netfilter_ipv4.h:19:54: note: expected ‘struct sock *’ but argument is of type ‘struct sk_buff *’ - - The build broke between Ubuntu-5.4.0-56.62 and Ubuntu-5.4.0-57.63, with - the changes introduced by commit "netfilter: use actual socket sk rather - than skb sk when routing harder" (Upstream commit - 46d6c5ae953cc0be38efd0e469284df7c4328cf8). - - This also breaks the dkms package in Bionic with the 5.4 kernels. ** Changed in: xtables-addons (Ubuntu) Status: New => Invalid ** Changed in: xtables-addons (Ubuntu) Status: Invalid => Fix Released ** Patch added: "Fix for xtables-addons in Focal" https://bugs.launchpad.net/ubuntu/+source/xtables-addons/+bug/1907109/+attachment/5441974/+files/xtables-addons_3.8-2ubuntu0.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1907109 Title: xtables-addons 3.0-0.1ubuntu4/3.8-2ubuntu0.1 fails to build with linux 5.4.0-57.63 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xtables-addons/+bug/1907109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
