** Description changed: + [Impact] + Building this module in focal against the new linux-hwe-5.8 returns the - following error: + following errors: /var/lib/dkms/v4l2loopback/0.12.3/build/v4l2loopback.c:137:47: warning: ‘struct timeval’ declared inside parameter list will not be visible outside of this definition or declaration - 137 | static inline void v4l2l_get_timestamp(struct timeval *tv) { - | ^~~~~~~ + 137 | static inline void v4l2l_get_timestamp(struct timeval *tv) { + | ^~~~~~~ /var/lib/dkms/v4l2loopback/0.12.3/build/v4l2loopback.c: In function ‘v4l2l_get_timestamp’: /var/lib/dkms/v4l2loopback/0.12.3/build/v4l2loopback.c:147:4: error: dereferencing pointer to incomplete type ‘struct timeval’ - 147 | tv->tv_sec = (time_t)ts.tv_sec; - | ^~ + 147 | tv->tv_sec = (time_t)ts.tv_sec; + | ^~ + ... + /var/lib/dkms/v4l2loopback/0.12.3/build/v4l2loopback.c:2441:44: error: ‘VFL_TYPE_GRABBER’ undeclared (first use in this function); did you mean ‘VFL_TYPE_SUBDEV’? + 2441 | if (video_register_device(devs[i]->vdev, VFL_TYPE_GRABBER, video_nr[i]) < 0) { + | ^~~~~~~~~~~~~~~~ + | VFL_TYPE_SUBDEV + cc1: some warnings being treated as errors + + + [Test case] + + $ sudo apt install v4l2loopback-dkms + + Build errors are reported in make.log. + + [Fix] + + Fix by adding some #ifdef's to properly support the struct timeval (that + is not available anymore in 5.8) and handle the rename of + VFL_TYPE_GRABBER to VFL_TYPE_VIDEO (in 5.8). + + [Regression potential] + + The source code for the 5.4 kernel remains the same, so there is no + regression potential. The new changes are all conditionals and they are + all applied to the 5.8 kernel.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1900997 Title: v4l2loopback: build error in focal with new kernel linux-hwe.5.8 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/v4l2loopback/+bug/1900997/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs