** Description changed: [Impact] - * An upstream change in libvirt 6.6 [1] broke logic if creating a pool - without an explicit yes/now for COW handling. + * An upstream change in libvirt 6.6 [1] broke the logic of creating a + pool without an explicit yes/no for COW handling. - * Another upstream patch in libvirt 6.7 [2] fixes the issue. + * Another upstream patch in libvirt 6.7 [2] fixes the issue. - * Backport the patch to avoid issues with tools like virt-manager but - also with any other automation that uses define+build via api or - cmdline + * Backport the patch to avoid issues with tools like virt-manager but + also with any other automation that uses define+build via api or + cmdline [1]: https://gitlab.com/libvirt/libvirt/-/commit/7230bc95aa78379c9ee20cf59394c5fc4305b75b [2]: https://gitlab.com/libvirt/libvirt/-/commit/2edd63a0dbd445112db23596ee0128521e8f1ff5 [Test Case] - * Define a dir pool and call pool-build: + * Define a dir pool and call pool-build: $ virsh pool-define-as --name home --type dir --target /home --print-xml > home.xml $ virsh pool-define home.xml $ virsh pool-build home error: Failed to build pool home error: unable to control COW flag on '/home', not btrfs: Function not implemented $ virsh pool-start home With the fix (and with e.g. 6.0 in Focal) this works, but with libvirt 6.6 missing the fix it fails as shown above. [Regression Potential] - * Gladly a one line change there aren't much side effects to consider. - It will help a certain set of use-cases and if anything could influence - actual execution on filesystems with COW support in that case btrfs. - Now onw might think "but hey this influences BTRFS behavior", but no it - does not. The change is inside a "if btrfs magic" section. Therefore - BTRFS will not change, only the non-btrfs cases (formerly broken) will. - This is one of the rare cases I really fail to see an explicit - regression - implicit ones e.g. due to needing a rebuild could still - happen. + * Gladly a one line change there aren't many side effects to consider. + It will help a certain set of use-cases and if anything could influence + actual execution on filesystems with COW support in that case btrfs. + Now one might think "but hey this influences BTRFS behavior", but no it + does not. The change is inside an "if btrfs magic" section. Therefore + BTRFS will not change, only the non-btrfs cases (formerly broken) will. + This is one of the rare cases I really fail to see an explicit + regression - implicit ones e.g. due to needing a rebuild could still + happen. [Other Info] - - * This is upstream issue: - https://bugzilla.redhat.com/show_bug.cgi?id=1866157 + * This is upstream issue: + https://bugzilla.redhat.com/show_bug.cgi?id=1866157 --- --- - Installed KVM and Virt-Manager successfully. When trying to add storage pool as local directory on my ext4 file system, I get this error: Error creating pool: Could not build storage pool: unable to control COW flag on '/var/lib/libvirt/images/pool', not btrfs: Function not implemented Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/asyncjob.py", line 75, in cb_wrapper callback(asyncjob, *args, **kwargs) File "/usr/share/virt-manager/virtManager/createpool.py", line 378, in _async_pool_create poolobj = pool.install(create=True, meter=meter, build=build) File "/usr/share/virt-manager/virtinst/storage.py", line 415, in install raise RuntimeError(errmsg) RuntimeError: Could not build storage pool: unable to control COW flag on '/var/lib/libvirt/images/pool', not btrfs: Function not implemented It seems that virt-manager is trying to disable the COW flag and returns an error because my file system is not BTRFS. Tested on 2 fresh installs of Ubuntu Studio 20.10 Tested on 1 install of Ubuntu 20.04.1 and virt-manager has no issues with local storage on ext4 file system. ProblemType: Bug DistroRelease: Ubuntu 20.10 Package: virt-manager 1:2.2.1-4ubuntu2 ProcVersionSignature: Ubuntu 5.8.0-25.26-lowlatency 5.8.14 Uname: Linux 5.8.0-25-lowlatency x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.20.11-0ubuntu50 Architecture: amd64 CasperMD5CheckResult: skip CurrentDesktop: KDE Date: Sat Oct 24 02:15:08 2020 InstallationDate: Installed on 2020-10-07 (16 days ago) InstallationMedia: Ubuntu-Studio 20.10 "Groovy Gorilla" - Beta amd64 (20200930) PackageArchitecture: all SourcePackage: virt-manager UpgradeStatus: No upgrade log present (probably fresh install)
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1901242 Title: virt-manager local directory storage failing To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1901242/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
