As you said on MM, looks like https://github.com/prometheus/common/commit/273427a9fd1 was added to allow to disable http/2, so it was being used already and this debdiff should not introduce a behavior change, which is good.
Have you checked which other rdeps fail to build? ** Description changed: [Impact] - The package FTBFS in Focal likely because a newer version of golang- - github-prometheus-common was introduced after prometheus-alertmanager - and a rebuild was not done. Not being able to build the package from - source does not allow uploads of eventual fixes (security or regular - ones) which is definitely not good for the users. + The package FTBFS in Focal because a newer version of golang-github- + prometheus-common was introduced after prometheus-alertmanager and a + rebuild was not done. Not being able to build the package from source + does not allow uploads of eventual fixes (security or regular ones) + which is definitely not good for the users. The Prometheus common lib API change which is impacting prometheus- alertmanager is minor. There is an extra argument in NewClientFromConfig function to enable or not HTTP/2. The proposed fix apply a patch enabling HTTP/2 in all the calls made to NewClientFromConfig. [Test Case] Try to build the package in Focal: $ lxc launch ubuntu-daily:focal builder $ lxc shell builder # echo "deb-src http://archive.ubuntu.com/ubuntu/ focal main universe" > \ /etc/apt/sources.list.d/source.list # apt update && apt upgrade -y # apt install -y dpkg-dev # apt source prometheus-alertmanager # apt build-dep -y prometheus-alertmanager # cd prometheus-alertmanager-0.15.3+ds # dpkg-buildpackage To fix the FTBFS apply the debdiff attached to this bug and build the package again. [Regression Potential] In the case where the user environment do not support HTTP/2 there might be a regression. HTTP/2 tries to be highly compatible with HTTP/1.1 but there might be any corner case. This would not be a change in the current behavior because this extra argument was added to allow users to disable it, check out this upstream commit: https://github.com/prometheus/common/commit/273427a9fd1 [Original Description] Currently, prometheus-alertmanager version 0.15.3+ds-3 FTBFS in Focal: https://paste.ubuntu.com/p/CcCYC3w3YC/ The Prometheus common golang library changed its API and the alertmanager version we have in Focal is not ready for it. ** Description changed: [Impact] The package FTBFS in Focal because a newer version of golang-github- prometheus-common was introduced after prometheus-alertmanager and a rebuild was not done. Not being able to build the package from source does not allow uploads of eventual fixes (security or regular ones) which is definitely not good for the users. The Prometheus common lib API change which is impacting prometheus- alertmanager is minor. There is an extra argument in NewClientFromConfig function to enable or not HTTP/2. The proposed fix apply a patch - enabling HTTP/2 in all the calls made to NewClientFromConfig. + enabling HTTP/2 in all the calls made to NewClientFromConfig, since this + was the previous behavior (http/2 enabled). [Test Case] Try to build the package in Focal: $ lxc launch ubuntu-daily:focal builder $ lxc shell builder # echo "deb-src http://archive.ubuntu.com/ubuntu/ focal main universe" > \ /etc/apt/sources.list.d/source.list # apt update && apt upgrade -y # apt install -y dpkg-dev # apt source prometheus-alertmanager # apt build-dep -y prometheus-alertmanager # cd prometheus-alertmanager-0.15.3+ds # dpkg-buildpackage To fix the FTBFS apply the debdiff attached to this bug and build the package again. [Regression Potential] In the case where the user environment do not support HTTP/2 there might be a regression. HTTP/2 tries to be highly compatible with HTTP/1.1 but there might be any corner case. This would not be a change in the current behavior because this extra argument was added to allow users to disable it, check out this upstream commit: https://github.com/prometheus/common/commit/273427a9fd1 [Original Description] Currently, prometheus-alertmanager version 0.15.3+ds-3 FTBFS in Focal: https://paste.ubuntu.com/p/CcCYC3w3YC/ The Prometheus common golang library changed its API and the alertmanager version we have in Focal is not ready for it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897967 Title: [SRU] FTBFS in Focal To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/prometheus-alertmanager/+bug/1897967/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
