[Summary]
MIR team ACK under the condition that the subscription is added and someone
takes a look at the build and autopkgtest tests.
This also does need a security review, so I'll assign ubuntu-security.
Specific binary packages to be promoted to main:
- golang-github-kardianos-service-dev
Required:
- subscribe foundations to the package
(Strongly) Recommended TODOs:
- Tests are actively disabled in d/rules atm, any chance to evalate, fix and
enable them?
- Also this integrates go packages with systemd which we know to change quite
a bit a autopkgtest would be awesome to ensure future systemd upgrades won't
break it.
I was torn if this is strictly required or recommended, foundations will own it
either way - with bugs detected early or late - so it is up to you. But I really
recommend adding/enabling tests on this one.
[Duplication]
There also is golang-gopkg-hlandau-service.v2-dev but that isn't in main.
So no other (Go) package in main providing the same functionality yet.
[Dependencies]
OK:
- no other Dependencies to MIR due to this (onlygolang-github-kardianos-osext
which is part of this MIR already)
- one -dev packages for auto-include but not crit dependencies
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking (well Go)
[Security]
OK:
- history of CVEs does not look concerning
- does not open a port
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
Problems:
- does run a daemon as root - running services is the core task of this.
So a lot of things might be set up right / wrong by it and therefore a
security evaluation should happen.
[Common blockers]
OK:
- does not FTBFS currently
- no translation present, but none needed for this case (user visible)?
- not a python package, no extra constraints to consider int hat regard
- Go package that uses dh-golang
TODO: Problems:
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a test suite that runs as autopkgtest
=> The build time tests are actively disabled and should be enabled if possible.
Also this integrates go packages with systemd which we know to change quite
a bit a autopkgtest would be awesome to ensure future systemd upgrades won't
break it.
- The package has no team bug subscriber (Should be Foundations, please
subscribe)
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Upstream update history is ok (code is 6 years old, only releases last
two years - but then steady)
- Debian/Ubuntu update history is ok
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- Does not have Built-Using
- Go Package that follows the Debian Go packaging guidelines
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (Go)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- no embedded source copies
- not part of the UI for extra checks
** Changed in: golang-github-kardianos-service (Ubuntu)
Assignee: Christian Ehrhardt (paelzer) => Ubuntu Security Team
(ubuntu-security)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1894731
Title:
[MIR] golang-*, Go build dependencies of google-guest-agent
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-github-gcp-guest-logging-go/+bug/1894731/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
