This is a very tricky SRU to be reviewing. Not having too much expertise in RCU, I need to rely on the opinion of people with more experience in this regard. Performance improvements like these are certainly SRUable, but we need to make sure that all the regression potential is covered and behavior for existing users stays relatively the same - at least without any ill-effects.
So Matthew, your analysis and rationale in #8 seems legit. The change also looks good, well documented and well contained. Also, the check for static-linking also seems to be reassuring. I think content-wise we're good to go here. What I'd like before we proceed is for Rafael to take a look at your analysis in comment #8 and say if that addresses his concerns as well (since as I said, I'd like someone with more expertise to also +1). @rafaeldtinoco could you take a look? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1876230 Title: liburcu: Enable MEMBARRIER_CMD_PRIVATE_EXPEDITED to address performance problems with MEMBARRIER_CMD_SHARED To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liburcu/+bug/1876230/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
