Thank you for looking into this issue. Reporting current status. == "mwifiex crash after suspend"
This issue might be the Surface devices specific problem? Not sure. I know some ways to prevent at least mwifiex crashing: 1. Disabling d3cold for wifi device (even doable on mainline kernels): echo 0 | sudo tee /sys/devices/pci0000:00/0000:00:1d.3/0000:03:00.0/d3cold_allowed # on SB1 echo 0 | sudo tee /sys/devices/pci0000:00/0000:00:1d.0/0000:02:00.0/d3cold_allowed # on SP4 2. Your patch "0001-mwifiex-set-PCIE-to-PCI_D0-power-state-on-resume" 3. Disable bridge_d3 on mwifiex_pcie_probe() pdev->bus->self->bridge_d3 = false; but with those ways, as I mentioned before (Comment 108), it sometimes not connect to AP automatically because it fails to find APs (`nmcli d wifi list` shows empty). This is easily fixed by reloading the "mwifiex_pcie" module. Patch for this issue we (linux-surface community) are currently using is, based this patch from sebanc: - https://github.com/jakeday/linux-surface/issues/420#issuecomment-544615371 Actual commit is here: - https://github.com/linux-surface/kernel/commit/c8da40c0538a1528f3efd85cd91d9e314c85dd19 The patch from sebanc does the following things: - modify mwifiex_pcie_suspend/mwifiex_pcie_resume functions to fix crash after suspend. It seems that the function mwifiex_pcie_suspend2 is from mwifiex_pcie_remove and the function mwifiex_pcie_resume2 is largely from mwifiex_pcie_probe. So, I think that it behaves in the same way as we unload modules before suspend and re-load modules after suspend. - disable bridge_d3 to fix crash after suspend - disable "auto deep sleep" (I think not needed for this issue, but introduced hoping to fix other issues) I think the patch is too aggressive to be upstreamed as they are, but please use it as a reference. The patch also fixes S0ix on KBL/KBL-R devices (such as Surface Book 2, Surface Pro 5, Surface Laptop 1 or later). SKL devices such as Surface Pro 4 or Surface Book 1 cannot achieve S0ix anyway because of other reasons outside of mwifiex. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1730924 Title: Wifi does down "crash" in Surface Pro 4 To manage notifications about this bug go to: https://bugs.launchpad.net/linux/+bug/1730924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs