** Description changed: - The rmap stressor should return EXIT_NO_RESOURCE and not EXIT_FAILURE - when attempting to fallocate a file to rmap onto. This makes it a non- - critical failure based on lack of resources rather than a stress test - failure because rmap failed. + == SRU Justification BIONIC, DISCO == + + When running the rmap stressor on systems with small file systems the + fallocate can fail to allocate a large file when running with may + stressors causing the stress test to exit with EXIT_FAILURE. The + correct return is actually EXIT_NO_RESOURCE as there are not enough + resources to run the stress-test. + + == Test Proceedure == + + Run rmap on a small file system with many stressors invoked, e.g. + + stress-ng --rmap 2048 -t 60 + + without the fix, the test will exit with a failure. With the fix the + stressor will terminate early with just an out of resource message + rather than a hard test failure. + + == Fix == + + upstream commit: + + commit 38fd9c6ff96cb7e73f7cb3758bb303d874ad11b5 + Author: Colin Ian King <[email protected]> + Date: Mon Sep 23 14:11:26 2019 +0100 + + stress-rmap: don't make fallocate failures a rmap test failure (LP: #1845005) + + The rmap stressor should return EXIT_NO_RESOURCE and not EXIT_FAILURE + when attempting to fallocate a file to rmap onto. This makes it a + non-critical failure based on lack of resources rather than a stress + test failure because rmap didn't fail per-se. + + Signed-off-by: Colin Ian King <[email protected]> + + == Regression Potential == + + This is a minor change to a return status and closing of opened + resources. The behaviour is now different on an allocation failure error + type, so applications running this stress test that checking a specific + error return may need updating. This is unlikely as most code checks for + 0 success and non-zero for failure. + + --------------------------------------------- + + + The rmap stressor should return EXIT_NO_RESOURCE and not EXIT_FAILURE when attempting to fallocate a file to rmap onto. This makes it a non-critical failure based on lack of resources rather than a stress test failure because rmap failed.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845005 Title: rmap stressor should return EXIT_NO_RESOURCE when out of free space To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/stress-ng/+bug/1845005/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
