The kernel also has code to perform the check for which kpatch uses the stack trace, i.e. that no task's call stack contains the function to be patched. This is performed by klp_check_stack(), via klp_enable_patch().
I'm not at all familiar with kpatch, but it kind of looks like there are two alternate modules which can be used for inserting livepatches into the kernel. One is in kmod/patch/kpatch-patch-hook.c, which does not use the klp_* interfaces exported by the kernel and does use kpatch's stack checking. The other is in kmod/patch/livepatch-patch-hook.c, which does use the klp_* interfaces and does not use kpatch's stack checking. So I wonder if the kpatch-patch-hook method is unused when the klp_* interfaces are available, and if so perhaps kpatch's internal stack checking is not needed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1837886 Title: kpatch 0.5.0-0ubuntu2 ADT test failure with linux 5.3.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/kpatch/+bug/1837886/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
