The code is four shell scripts which still have a lot of findings in shellcheck. As usual the majority are minor issues, but unused variables and word split can often lead to real bad/unexpected behavior later on.
I'm continuing the review, but do you think we could rais this upstream to get at least the worse parts of it fixed? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835114 Title: [MIR] ec2-instance-connect To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-instance-connect/+bug/1835114/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
