Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled
Review of attachment 594363: ----------------------------------------------------------------- Sorry for the delay. I've had this on my mind for a while though. My main problem here is that this doesn't really do what the end goal of this bug is. This simply removes a check from the dialog path, but it doesn't handle the keyboard case at all, which is what we really want. So I think we should move discussion about this specifically to a new bug. Since this is (mostly) only going to affect people who manually gone & changed showQuitWarning to true & have sessionstore on, it shouldn't be too disruptive. Though, we'll show the quit dialog which asks about saving tabs when session restore is already on... so that's not ok. Also, all the people quitting by closing the last window will suddenly have a dialog in their face, event without showQuitWarning (I think I take back "shouldn't be too disruptive"). We can discuss more in a new bug if you file it -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
