I looked at the neutron-fwaas-dashboard package in the xenial NEW queue and I have some question. There are obviously some differences between 1.3.0 in cosmic and the one backported to bionic. This makes the review a bit less straightforward as our regular SRU NEW package-backport policies do not apply.
The most obvious changes are the ones from py3 -> py2 which has been explained in this bug, so I'll skip that part. There are some others that I'd first want to know some about . 1) I noticed that in the cosmic package the tests were ran during override_dh_install (which did seem a bit strange to me) but now have moved to the proper place in override_dh_auto_test. What was the reason that it was previously done at a different step? 2) In the original cosmic package, in override_dh_install I see that some static files were being copied over to /usr/share/openstack- dashboard/openstack_dashboard/static etc. which is not happening anymore in the bionic backport. Everything else moved to override_dh_auto_install. Are those now installed as part of pkgos- dh_auto_install ? Why did the installation stages move so much? 3) This is a minor question (out of curiosity), just wanted to get some context on this: why is 1.3.0 backported instead of 1.5.0? Not a problem of course. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1808168 Title: Neutron FWaaS panel missing from dashboard on Queens To manage notifications about this bug go to: https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1808168/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
