* -doc package: I think we should promote it as well in main, if the -dev is promoted. If so, this dep should be fixed: Depends: lynx | www-browser (first is lynx, in universe, www-browser is a virtual package not fullfiled?). In addition, it ships the doc in devhelp format (despite symlink from doc/ to gtk-doc/). I don't think anyway that those are needed, we don't tend to have -doc dep on a browser implementation. * NEWS file has: 0.9.2 - Remove the old gupnp-dlna-1.1.pc.in file. / Remove gupnp and gstreamer-* dependencies from VAPI file generation. I think the build-dep on libgupnp-1.0-dev may thus be optional (only used for VAPI file, see "Note to self" below). Do you mind checking? * Any progress on getting the usptream testsuite running during package build and autopkgtests? * debian/copyright has some missing copyright notices: Copyright: 2012-2013 Intel Corporation for instance in * as GPL-2.0+ I think that's the only missing one, but better to double check * 2 of the 4 lintian warning worth fixing IMHO: W: libgupnp-dlna-2.0-dev: gir-missing-typelib-dependency usr/share/gir-1.0/GUPnPDLNAGst-2.0.gir gir1.2-gupnpdlnagst-2.0 -> dep from the -dev on the gir* W: gir1.2-gupnpdlna-2.0: typelib-package-name-does-not-match usr/lib/x86_64-linux-gnu/girepository-1.0/GUPnPDLNAGst-2.0.typelib gir1.2-gupnpdlnagst-2.0 <- this one worth only an override IMHO + an explanation.
Minor: - VCS could be updated in debian/control* Note to self/remarks: * I was surprised to find the build-dep on libgupnp-1.0-dev on this universe package. I checked the binary packages though, and there is no dep on libgupnp-1.0-4. It's not statically linked either, but only used for generated the vapi file. I think some of the stuff should be addressed like test running before I give my +1. Then, as this is a network protocole (as for the whole dlna stack), I will defer to the security team for a review from a security perspective. I didn't spot anything crazy in the code itself, but I prefer deferring to experts :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
