Doko asked me to look at the package and it seems OK to me on a quick
glance. (Only spent a few minutes, let me know if you'd like a deeper
review!)

On the packaging side, I'm a bit surprised at the use of go:generate to
create the shared lib but it works I guess. Another thing that's more on
the taste side is that rather than knowing that debhelper puts build
artefacts in obj-$(DEB_HOST_GNU_TYPE), I prefer to pass
--builddirectory=_build or whatever to dh.

I'd generally be happier if the vendor directory wasn't in the source
tarball at all (which would also get you out of updating
debian/copyright :-p). I think you can do this by putting tar-ignore
=ubuntu-report/vendor into debian/source/options? (Side comment: why is
debian/ in .gitignore??)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1759540

Title:
  [MIR] ubuntu-report: send telemetry data to ubuntu server

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1759540/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to