This does not look right to me:

@@ -951,6 +952,7 @@
                 free(s->fifo_path);
                 s->fifo_path = NULL;
         }
+        session_add_to_gc_queue(s);
 }
 
 int session_check_gc(Session *s, bool drop_not_started) {


that puts the session on the manager's gc queue, however this function 
(session_remove_fifo) is called from session_free(), which is called from the 
manager's gc queue handler...can you explain why this is needed here?

The other parts of the patch look good, thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1750013

Title:
  systemd-logind: memory leaks on session's connections (trusty-only)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1750013/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to