Public bug reported:

[Impact]
Commit 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power saving") 
adds powersaving support for device-ids 5249 524a and 525a.
But as a side effect it breaks ASPM support for all the other device-ids, 
causing e.g. the Haswell CPU on a Lenovo T440s to not go into a higher c-state 
then PC3, while previously it would go to PC7, causing the machine to idle at 
7.4W instead of 6.6W!

[Fix]
The default dev_aspm_mode 0 is mapped to DEV_ASPM_DISABLE, but the old behavior 
of calling rtsx_pci_enable_aspm() when idle and rtsx_pci_disable_aspm() when 
busy happens when dev_aspm_mode == DEV_ASPM_DYNAMIC.
This commit changes the enum so that 0 = DEV_ASPM_DYNAMIC matching the old 
default behavior, fixing the pm regression with the other device-ids.

[Regression Potential]
No, it fixes the regression and set it back to the old value, so should be no 
regression potential.

** Affects: linux-oem (Ubuntu)
     Importance: Undecided
     Assignee: AceLan Kao (acelankao)
         Status: In Progress

** Patch added: "0001-mfd-Fix-RTS5227-and-others-powermanagement.patch"
   
https://bugs.launchpad.net/bugs/1743516/+attachment/5037691/+files/0001-mfd-Fix-RTS5227-and-others-powermanagement.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1743516

Title:
  Realtek card reader power consumption issue

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-oem/+bug/1743516/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to