The function is rather old:
dc12cec6 Wed Sep 3 18:54:56 2014 util: storage: Convert disk locality check to
switch statement
But the usage of it from the iterator is not:
commit c3a83bad2aa69a26d03ee8a0b817234f0f78b4a5
Author: Michal Privoznik <mpriv...@redhat.com>
Date: Thu Mar 30 17:02:39 2017 +0200
virDomainDiskDefForeachPath: Prefer virStorageSourceIsLocalStorage
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1b0a55b..01553b5 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -25342,10 +25342,8 @@ virDomainDiskDefForeachPath(virDomainDiskDefPtr disk,
}
for (tmp = disk->src; tmp; tmp = tmp->backingStore) {
- int actualType = virStorageSourceGetActualType(tmp);
/* execute the callback only for local storage */
- if (actualType != VIR_STORAGE_TYPE_NETWORK &&
- actualType != VIR_STORAGE_TYPE_VOLUME &&
+ if (virStorageSourceIsLocalStorage(tmp) &&
tmp->path) {
if (iter(disk, tmp->path, depth, opaque) < 0)
goto cleanup;
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1704782
Title:
qcow base image apparmor rule missing in artful
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1704782/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
