Validated no /sbin/blkid leaks from altcloud unit tests in xenial:
$ name=test-proposed $ release=xenial $ ref=$release-proposed $ ./lxc-proposed-snapshot --proposed --publish $release $ref $ lxc init $ref $name Creating test-proposed $ lxc exec $name -- git clone -b ubuntu/xenial https://git.launchpad.net/cloud-init; ... $ lxc exec $name bash root@test-proposed:~/cloud-init# tox -e py27 tests/unittests/test_datasource/test_altcloud.py | grep 'LEAKED BLKID' # None reported root@test-proposed:~/cloud-init# /sbin/blkid LEAKED BLKID CALL $ lxc exec $name -- dpkg -l cloud-init ii cloud-init 0.7.9-113-g5 all Init scripts for cloud instances ** Description changed: === Begin SRU Template === [Impact] - Unit test updates to avoid leaking blkid calls from tests/unittests/test_datasource/test_altcloud.py. + Unit test updates to avoid leaking blkid calls from tests/unittests/test_datasource/test_altcloud.py. [Test Case] wget https://git.launchpad.net/~smoser/cloud-init/+git/sru- info/plain/bin/lxc-proposed-snapshot chmod 755 lxc-proposed-snapshot - # Create fake-blkid.sh cat fake-blkid.sh #!/bin/bash echo "LEAKED BLKID CALL" name=proposed-test for release in xenial yakkety zesty; do \ - ref=$release-proposed; - ./lxc-proposed-snapshot --proposed --publish $release $ref; - lxc init $ref $name; - lxc start $name; - sleep 10; - lxc exec $name mv /sbin/blkid /sbin/blkid.orig; - lxc file push fake-flkid.sh $name/sbin/blkid - lxc exec $name git clone -b ubuntu/xenial https://git.launchpad.net/cloud-init - tox -e py27 tests/unittests/test_datasource/test_altcloud.py | grep 'LEAKED BLKID'; + ref=$release-proposed; + ./lxc-proposed-snapshot --proposed --publish $release $ref; + lxc init $ref $name; + lxc start $name; + sleep 10; + lxc exec $name -- mv /sbin/blkid /sbin/blkid.orig; + lxc file push fake-flkid.sh $name/sbin/blkid + lxc exec $name -- git clone -b ubuntu/xenial https://git.launchpad.net/cloud-init + tox -e py27 tests/unittests/test_datasource/test_altcloud.py | grep 'LEAKED BLKID'; done - - [Regression Potential] + + [Regression Potential] None. Unit test changes only [Other Info] === End SRU Template === - - Running the unittests on our slave s390x system, the blkid command fails. Running it manually returns the following: + Running the unittests on our slave s390x system, the blkid command + fails. Running it manually returns the following: jenkins@s1lp04:~$ blkid -tLABEL=CDROM -odevice jenkins@s1lp04:~$ echo $? 2 jenkins@s1lp04:~$ lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT dasda 94:0 0 20.6G 0 disk |-dasda1 94:1 0 19.7G 0 part / `-dasda2 94:2 0 953.5M 0 part [SWAP] Full run output: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=s390x/53/console ** Description changed: === Begin SRU Template === [Impact] Unit test updates to avoid leaking blkid calls from tests/unittests/test_datasource/test_altcloud.py. [Test Case] wget https://git.launchpad.net/~smoser/cloud-init/+git/sru- info/plain/bin/lxc-proposed-snapshot chmod 755 lxc-proposed-snapshot # Create fake-blkid.sh cat fake-blkid.sh #!/bin/bash echo "LEAKED BLKID CALL" name=proposed-test for release in xenial yakkety zesty; do \ ref=$release-proposed; ./lxc-proposed-snapshot --proposed --publish $release $ref; lxc init $ref $name; lxc start $name; sleep 10; lxc exec $name -- mv /sbin/blkid /sbin/blkid.orig; - lxc file push fake-flkid.sh $name/sbin/blkid - lxc exec $name -- git clone -b ubuntu/xenial https://git.launchpad.net/cloud-init + chmod 755 fake-blkid.sh; + lxc file push fake-blkid.sh $name/sbin/blkid; + lxc exec $name -- git clone -b ubuntu/xenial https://git.launchpad.net/cloud-init; tox -e py27 tests/unittests/test_datasource/test_altcloud.py | grep 'LEAKED BLKID'; done [Regression Potential] None. Unit test changes only [Other Info] === End SRU Template === Running the unittests on our slave s390x system, the blkid command fails. Running it manually returns the following: jenkins@s1lp04:~$ blkid -tLABEL=CDROM -odevice jenkins@s1lp04:~$ echo $? 2 jenkins@s1lp04:~$ lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT dasda 94:0 0 20.6G 0 disk |-dasda1 94:1 0 19.7G 0 part / `-dasda2 94:2 0 953.5M 0 part [SWAP] Full run output: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=s390x/53/console ** Description changed: === Begin SRU Template === [Impact] Unit test updates to avoid leaking blkid calls from tests/unittests/test_datasource/test_altcloud.py. [Test Case] wget https://git.launchpad.net/~smoser/cloud-init/+git/sru- info/plain/bin/lxc-proposed-snapshot chmod 755 lxc-proposed-snapshot # Create fake-blkid.sh cat fake-blkid.sh #!/bin/bash echo "LEAKED BLKID CALL" name=proposed-test for release in xenial yakkety zesty; do \ ref=$release-proposed; ./lxc-proposed-snapshot --proposed --publish $release $ref; lxc init $ref $name; lxc start $name; sleep 10; lxc exec $name -- mv /sbin/blkid /sbin/blkid.orig; - chmod 755 fake-blkid.sh; + chmod 755 fake-blkid.sh; lxc file push fake-blkid.sh $name/sbin/blkid; lxc exec $name -- git clone -b ubuntu/xenial https://git.launchpad.net/cloud-init; + lxc exec $name -- sudo apt install tox -y; tox -e py27 tests/unittests/test_datasource/test_altcloud.py | grep 'LEAKED BLKID'; done [Regression Potential] None. Unit test changes only [Other Info] === End SRU Template === Running the unittests on our slave s390x system, the blkid command fails. Running it manually returns the following: jenkins@s1lp04:~$ blkid -tLABEL=CDROM -odevice jenkins@s1lp04:~$ echo $? 2 jenkins@s1lp04:~$ lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT dasda 94:0 0 20.6G 0 disk |-dasda1 94:1 0 19.7G 0 part / `-dasda2 94:2 0 953.5M 0 part [SWAP] Full run output: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=s390x/53/console ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1636531 Title: unittests blkid command fails on slave s390x To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-init/+bug/1636531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
