I'll note that 'peer_store' isn't safe to directly call, but looking at the 
traceback of the original description it is line ~217 of 
hooks/amqp-relation-changed which looks to be:
    # If this node is the elected leader then share our secret with other nodes
    if is_elected_leader('grp_ceilometer_vips'):
        peer_store('shared_secret', get_shared_secret())

And 'is_elected_leader' is just a call to 'is-leader' with a bunch of
other stuff if 'is-leader' doesn't exist.

So I can't see anything functionally wrong with the code. It does,
indeed, appear to be checking before it actually does the work.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1654116

Title:
  Attempts to write leadership settings when not the leader during
  relation-changed hooks

To manage notifications about this bug go to:
https://bugs.launchpad.net/autopilot-log-analyser/+bug/1654116/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to