Hi, thanks for the quick response. I'm more than happy for this to wait for Xenial.
I wasn't aware there was going to be a 5.7. The page for 5.7 on the PHP wiki suggests that it was a proposal that wasn't accepted: https://wiki.php.net/rfc/php57 If I'm wrong about this then I'm happy to work with upstream to get it into 5.7, but it looks like they want all changes to go into php7 instead. If you're referring to php7, then yes, this stuff does go away in PHP7. However, I think there will still be a lot of people on php5 for some time (think how long people stayed with php4!), so it'd be nice to have that perform better. I accept that there is risk associated with taking this patch. For two reasons, I think the risk is minimal. Firstly, I would be very surprised if people were compiling their custom server backends against Ubuntu's source tree: I'd expect they'd compile against mainline. Secondly, even if they compiled against Ubuntu, they would need to depend on HANDLE_BLOCK_INTERRUPTIONS to experience an issue. Of all the server APIs ever bundled with PHP, only Apache1 ever provided these hooks. All of the (many!) other servers that PHP5 provided support for didn't use these hooks. If it were a 1 or 2% speed boost, I'd agree that it's not worth it. However, given that it's closer to 5%, I think it's worth the work to get it in. Thanks again, and I'm happy to address any further concerns you have. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1527105 Title: Performance: drop HANDLE_BLOCK_INTERRUPTIONS support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1527105/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
