** Description changed: I noticed this when installing ppc64el, as boot would fail. It would fail because no /boot/grub/grub.cfg existed. I'm not entirely sure when we need to run update-grub. I know that the 'install_grub' was choosing to *not* run update-grub because sometimes dpkg-reconfigure would do the same thing, and that was a slow operation. Its possible there are more complex symantics involved than I understood. But we were not running 'update-grub' in order to save some time. Basically, as input to 'install_grub', we have: - * the target to install to (/dev/sda1 or /dev/sda) - * the dpkg arch - * the name of the package to 'dpkg-reconfigure' (derived from the dpkg arch and whether or not to use uefi). - we dpkg-reconfigure because we may change the GRUB_CMDLINE_LINUX_DEFAULT to include additional options such as console= + * the target to install to (/dev/sda1 or /dev/sda) + * the dpkg arch + * the name of the package to 'dpkg-reconfigure' (derived from the dpkg arch and whether or not to use uefi). + we dpkg-reconfigure because we may change the GRUB_CMDLINE_LINUX_DEFAULT to include additional options such as console= From my memory, it seemed like on amd64 and i386, running 'dpkg- reconfigure grub-pc' would end up running update-grub. I then chose not to run update-grub because it was slow. Colin, Is there some simple logic that I can use to determine when running update-grub is needed? + + + SRU curtin + ========== + + [Impact] + + This bug will make it so boot fails when installing ppc64el. It would + fail because no /boot/grub/grub.cfg existed. + + This backport is needed so that we can install for ppc64el and any other + architectures that were failing because update-grub was not being + executed when doing grub-install. + + This upload fixes the bug by making sure that update-grub is executed + when doing grub-install + + + [Test Case] + + To reproduce this bug you would need to follow what was being done as + outlined in the original bug report description. Namely, you would need + to do a curtin install for ppc64el. + + + [Regression Potential] + + update-grub can be run multiple times so even in the event that update- + grub is executed a second time by some other package, like the original + bug reporter mentions in the original bug report description, it is + unlikely to cause any regressions.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1373137 Title: need to run update-grub when grub-install To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1373137/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
