The patch you showed was incorrect, it was corrected by a later patch: https://hg.libsdl.org/SDL/rev/ede9d13dad21
I'll update the SRU template to reflect that. ** Description changed: I believe something is wrong with MIR support. A daily build of openmw just failed with: /usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory #include <mir_toolkit/mir_client_library.h> In SDL_syswm.h: #if defined(SDL_VIDEO_DRIVER_MIR) #include <mir_toolkit/mir_client_library.h> #endif the file is: /usr/include/mirclient/mir_toolkit/mir_client_library.h http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any openmw buildlog: https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz it built successfully until the fix for bug #1295389 libsdl2 commit hit that enabled mir. Assigning "high" since it has the potentially to cause a large number of FTBFS in the archive. SRU Info: *Note* This patch has landed in libsdl2 upstream: - https://hg.libsdl.org/SDL/rev/274017846e73 + https://hg.libsdl.org/SDL/rev/ede9d13dad21 + (which also reverts https://hg.libsdl.org/SDL/rev/274017846e73) 1) The issue is we include mir_client_library.h, meaning everything that compiles sdl2 apps will need to include this as well. So we need to forward declare the structs so we don't need to include the mir header. 2) A simple way to test the current Mir problem: http://paste.ubuntu.com/7271077/ - 3) Regression potential: Very low, this is a 1 line patch, that adds the - MIR_CFLAGS to the SDL_CFLAGS. + 3) Regression potential: Low - upstream has had this change for a month + without problem -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1306629 Title: [SRU] SDL_syswm.h can't find mir_toolkit/mir_client_library.h To manage notifications about this bug go to: https://bugs.launchpad.net/mir/+bug/1306629/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
