Hey Mattia,

there are a few nitpicks with this, and I figure as you are an aspiring
MOTU I'd rather tell you about them than just fixing them.

 * The package has a Vcs-Bzr:, thus merges should be done against that
branch. However, as it seems the desktop team pretty much lost interest
in this and the last few commits were just retroactively committed, I'm
actually in favor of reverting the Vcs-* change, leave Debian's git, and
drop our ubuntu specific Vcs branch.

 * The extra or changed Replaces: were only necessary for earlier
upgrades, that delta can be reverted now that trusty is out.

 * Since xscreensaver has not been installed on ubuntu/kubuntu/etc. for
a long time, and is only being used in Mythbuntu and Ubuntustudio, I
wonder whether the rather intrusive change for moving some screen savers
between packages is still necessary. Perhaps you can ping the leads of
these two derivatives to check whether we can drop this?

 * I suppose debian/xscreensaver.dirs isn't necessary, I'm fairly sure
that the "make install" bits will create directories by themselves.
(That needs to be double-checked of course)

Thanks!

** Changed in: xscreensaver (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1283459

Title:
  Please merge xscreensaver (5.26-1) from Debian unstable

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/1283459/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to