Launchpad has imported 8 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=35797.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-03-30T07:34:48+00:00 Michael Terry wrote:

Created attachment 45048
Adds signal arg

In Ubuntu, we got a bug filed about how suspends initiated outside of
gnome-power-manager were not locking the screen correctly.

This is because it handled locking as a result of internal methods, not
as a response to the Sleeping signal from upower.  Ideally it would do
that instead, but first, that signal needs to have enough information
for a policy agent like gnome-power-manager to determine policy.

Which means it needs to tell listeners whether the sleep is a suspend or
hibernate.

We received a patch for this by Phillip Susi (attached).  It simply adds
an int argument to the signal.  Will existing dbus listeners be confused
by the addition of a new argument?

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/18

------------------------------------------------------------------------
On 2011-03-30T08:05:44+00:00 Richard Hughes wrote:

Yup, see http://lists.freedesktop.org/archives/devkit-
devel/2011-March/001054.html

And yes, adding an argument will upset people.

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/19

------------------------------------------------------------------------
On 2011-03-30T08:12:38+00:00 Michael Terry wrote:

Ah, sorry, searched bugs, but didn't think about the mailing list.

What about a second signal, named "SleepingFull" or something?

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/20

------------------------------------------------------------------------
On 2011-03-30T10:14:13+00:00 Richard Hughes wrote:

SleepingFull might be best, I though perhaps Sleeping2, but both seem
non-ideal. Got any better ideas?

Richard.

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/21

------------------------------------------------------------------------
On 2011-03-30T10:17:54+00:00 Michael Terry wrote:

The only alternative to a second signal I can think of is a query method
like GetCurrentSleepType(), but that's a whole 'nother round trip eating
into the precious second before suspend (I don't know how much of a
concern that is).

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/22

------------------------------------------------------------------------
On 2011-03-30T10:18:59+00:00 Michael Terry wrote:

Oh, I think you meant naming ideas?  SleepingWithType?

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/23

------------------------------------------------------------------------
On 2011-03-30T10:24:53+00:00 Richard Hughes wrote:

(In reply to comment #4)
> The only alternative to a second signal I can think of is a query method like
> GetCurrentSleepType(), but that's a whole 'nother round trip eating into the
> precious second before suspend (I don't know how much of a concern that is).

Eek. RTT is probably too high for that. Even setting a property might be
racy, I'm not sure. A PropertyChanged signal in GDBus is run in a new
thread, and I'm not sure how it works when we're using the clunky dbus-
glib.

At the moment I'm erring for ::SleepingKind and ::ResumingKind as we
call things kinds internally (rather than type, which upsets glib
sometimes).

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/24

------------------------------------------------------------------------
On 2013-10-12T22:52:43+00:00 Bugzilla-x wrote:

The Sleeping signal is deprecated, and removed in my branch. We won't
get a new signal.

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-power-
manager/+bug/578542/comments/26


** Changed in: upower
       Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/578542

Title:
  resuming from S3 wrongly prompts for password

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-power/+bug/578542/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to