On Mon, 2007-07-23 at 17:22 +0000, Johan Kiviniemi wrote: > Is there a reason for patching the xv driver to support both compiz > video and xv instead of creating a separate compiz video output driver > for mplayer, which would then fall back to xv if compiz video isn’t > available? All other output methods have separate plugins (e.g. xv, x11, > opengl, sdl, framebuffer). > > Seems to me that hacking the compiz video functionality to the xv driver > makes both harder to maintain and enhance. For instance, the xv driver > only allows the OSD and subtitle overlays to be drawn to the original > video frames before they’re scaled to the target size. On the other > hand, the compiz video driver would be able to use composited overlays > for OSD and subtitles. They wouldn’t be dependent on the video > resolution and aspect ratio.
This is indeed the suggested course, although having it in the xv driver does allow it to seamlessly fall back on Xv if the compiz plugin goes away while the video is playing. The original patch is somewhat of a proof-of-concept, really, although it does work. -- Use Compiz' "video" plugin when available https://bugs.launchpad.net/bugs/121476 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
