Launchpad has imported 6 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=62016.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2013-03-08T10:58:55+00:00 Martin Pitt wrote: Various pam modules provide environment variables that are intended to be set in the environment of the pam session. pkexec needs to process the output of pam_getenvlist() to get these. This will e. g. apply correct locales in pkexec when they are configured in pam_environment. Reply at: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/982684/comments/23 ------------------------------------------------------------------------ On 2013-03-08T11:01:25+00:00 Martin Pitt wrote: Created attachment 76150 pkexec: Set process environment from pam_getenvlist() Steve Langasek applied this patch a while ago to the Ubuntu packages. I adjusted it for current git master and brought it into git format-patch form. Reply at: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/982684/comments/24 ------------------------------------------------------------------------ On 2013-03-08T18:06:28+00:00 Zeuthen wrote: I'm not sure that's a good idea ... but I can probably be convinced that it is :-) ... So apart from locales, can you give examples of such PAM modules and the environment variables that are set? Thanks. Reply at: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/982684/comments/25 ------------------------------------------------------------------------ On 2013-03-08T18:08:38+00:00 Zeuthen wrote: Comment on attachment 76150 pkexec: Set process environment from pam_getenvlist() Review of attachment 76150: ----------------------------------------------------------------- Looks good but the the coding style is wrong - curly-braces / indentation wrong - should use guint instead of int - should use 'n' as a counter/iterator, not 'i' (like the rest of the code) These are style issues but consistency is important. Reply at: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/982684/comments/26 ------------------------------------------------------------------------ On 2013-03-11T08:31:41+00:00 Steve Langasek wrote: On Fri, Mar 08, 2013 at 06:06:28PM +0000, bugzilla-dae...@freedesktop.org wrote: > ... So apart from locales, can you give examples of such PAM modules and > the environment variables that are set? Thanks. The pam_env module is a big one, which is used by admins to configure arbitrary environment settings for all sessions. The specific case that prompted this had to do with proxy settings configured in the environment. Other modules that may need to set environment variables include pam_krb5 and pam_afs_session, whose environment settings may be required for proper filesystem access. Reply at: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/982684/comments/27 ------------------------------------------------------------------------ On 2013-03-11T08:48:38+00:00 Martin Pitt wrote: Created attachment 76324 pkexec: Set process environment from pam_getenvlist() Fixed coding style. Reply at: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/982684/comments/28 ** Changed in: policykit Status: Unknown => Incomplete ** Changed in: policykit Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/982684 Title: sudo, pkexec don't apply global environment settings from /etc/environment To manage notifications about this bug go to: https://bugs.launchpad.net/policykit/+bug/982684/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
