I've looked at the SSDTs and we've got _GTF methods as follows:

            Method (_GTF, 0, NotSerialized)
            {
                Store (Zero, CMDC)
                If (LOr (DSSP, FHPP))                # this is the bug
                {
                    GTFB (STFD, 0x06)
                }
                Else
                {
                    GTFB (STFE, 0x06)
                }

                GTFB (FZTF, Zero)
                GTFB (DCFL, Zero)
                Return (SCBF)
            }

The LOr opcode is acceessing DSSP which is declared earlier as:

External (DSSP)

however, it is not defined in any of the DSDT or SSDTs which is a bug.
I've loaded the tables with acpiexec and dumped the object namespace to
sanity check this and again did not find a DSSP object.  So it looks
like this is buggy firmware.

The ramification is that the SATA _GTF controls are buggy and are
failing.  I've not much experience of _GTF controls, they appear in
section 9.8.1.1 of version 5 of the ACPI spec:

"This optional object returns a buffer containing the ATA commands used to 
restore the drive to boot
up defaults (that is, the state of the drive after POST). The returned buffer 
is an array with each
element in the array consisting of seven 8-bit register values (56 bits) 
corresponding to ATA task
registers 1F1 thru 1F7. Each entry in the array defines a command to the drive."

..my guess is that if these are needed and we're not working then resume
would be failing.  So it seems like this is a firmware bug and needs the
OEM to look at it, but as it stands, resume is working OK, so it may not
be necessary.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1153421

Title:
  HP Envy 23 AIO - Various FWTS failures when testing

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1153421/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to