Bryce, therere are few things that needs to be cleared of:

""general, including commercial games. Including this package in main will 
address an issue that inhibits a number of games from "just working"."".
What's the goal for having this library in main? The packages from the Inidie 
humble bundle  will dep on it, and so install it when needed, isn't it? How is 
that preventing commercial games for Ubuntu?
You maybe mean not packaged application, and so you want to install s2tc by 
default, not just seed it in supported?
Please clarify.


* A basic test suite is included in the package, however it requires network 
access (it downloads jpgs from various game sites)
Can we have a test debtag then, so that the test suite is run in our QA 
datacenter?

* on the package itself, the patch debian/patches/01-library-rename.patch is 
renaming the library for the dynamic linking object:
-s2tc_compress_LDADD = -ltxc_dxtn
-s2tc_decompress_LDADD = -ltxc_dxtn
+s2tc_compress_LDADD = -ltxc_dxtn_s2tc
+s2tc_decompress_LDADD = -ltxc_dxtn_s2tc
So, I guess the game has to be explicitely recompile against our version. The 
"not packaged application" is then not addressed. I do not see why this library 
won't just be a dep on the game then (and don't need main promotion). Even if I 
do see we are using an alternative for it (but multiarched)

* just a nitpick: would be nice to have debian/copyright corresponding
to latest DEP5.

Other than that, the packaging and code seems good to me.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1053065

Title:
  MIR for s2tc, required by various games

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/s2tc/+bug/1053065/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to