Review:
 * No CVEs. Hardening options are enabled, but it would be nice to have this 
compiled with PIE. No initscripts/upstart jobs, dbus services, setuid, use of 
fscaps, use of sudoe/su/pkexec, or cron jobs
 * coded in typical C++ and looks to have appropriate SSL handling. Spot 
checking code looks fine.
 * Has testsuite and it is enabled in the build
 * libqtwebkit-dev dependency is thankfully dropped
 * no errors or important warnings in the build
 * is not lintian clean:
signon-plugin-oauth2-tests_0.11-0ubuntu2_amd64.deb:
W: signon-plugin-oauth2-tests: binary-without-manpage usr/bin/oauthclient
W: signon-plugin-oauth2-tests: binary-without-manpage 
usr/bin/signon-oauth2plugin-tests

ACK

** Changed in: signon-plugin-oauth2 (Ubuntu)
       Status: New => Fix Committed

** Changed in: signon-plugin-oauth2 (Ubuntu)
     Assignee: Jamie Strandboge (jdstrand) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1029549

Title:
  [MIR] online-accounts and friends

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/account-plugins/+bug/1029549/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to