Reviewed signon-keyring-extension from NEW. Blockers: * Tests are disabled but Ken tells me some work is going into mocking gnome-keyring in order to enable the tests, which sounds good.
Nits: Would be nice to use debhelper compat 9. Package installs /usr/bin unnecessarily (debian/rule can just rm -rf .../usr/bin instead of rm -f .../usr/bin/keyring-test). I would prefer to see this using libsecret, but since that barely got uploaded to the archive itself, I understand. But note that libsecret is preferred over libgnome-keyring in GNOME now. This will likely need a rebuild after signon uses multiarch to put the plugin in the right directory, just FYI. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1029549 Title: [MIR] online-accounts and friends To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libaccounts-glib/+bug/1029549/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
