** Description changed: I just finished packaging display-dhammapada for Fedora and so went through this package. - 1. The man page needs updating as it contains undefined macros and dead links / url. - I have added those as attachments + 1. The man page needs updating as it contains undefined macros and dead + links / url. - 2. When reviewing the package, the Makefile appears to be intended to be - run as root. This is sort of outdated as most packaging is done as users - using fakeroot. I had to patch the Makefile for Fedora, you may wish to - review this in the .deb + see below for patchs + patch display-dhammapada.1 + patch display-dhammapada.1.in + + + 2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb + + If you wish, I can attach my Makefile as a patch, but, rmp packaging is + different from deb, so much of it is defined in the (rpm) .spec + + What you will want to look at is + + a. Packaging as a user, not root. + b. Ownership and permissions of files. + c. The c-flags. You may or may not wish to update the cflags. + d. The path (see #3) for files. 3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share + in display-dhammapada.c + + See patch display-dhammapada.c + 4. I think the file examples/xsession should start with a shee-bang + + #! /bin/sh I will report this on Debian as well, not sure how active upstream (from Debian) is ...
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1014195 Title: documentation needs updating To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
